Prevent console errors when clicking to change page while in Presentation Mode (issue 8498) #8499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Mode (issue 8498) The click handler used in Presentation Mode didn't check if the first/last page was already reached, which after PR 7529 now causes an unnecessary console error. Hence we should simply use the already existing `_goToPreviousPage`/`_goToNextPage` methods instead, since they do the necessary bounds checking. Fixes 8498.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/00ed258777a6586/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/00ed258777a6586/output.txt Total script time: 2.15 mins Published |
timvandermeij
approved these changes
Jun 7, 2017
|
Looks good. Thank you! |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
Prevent console errors when clicking to change page while in Presentation Mode (issue 8498)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The click handler used in Presentation Mode didn't check if the first/last page was already reached, which after PR #7529 now causes an unnecessary console error.
Hence we should simply use the already existing
_goToPreviousPage/_goToNextPagemethods instead, since they do the necessary bounds checking.Fixes #8498.