Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only mask char codes of (3, 0) cmap tables in the range of 0xF000 to 0… #8592

Merged
merged 1 commit into from
Jul 4, 2017
Merged

Only mask char codes of (3, 0) cmap tables in the range of 0xF000 to 0… #8592

merged 1 commit into from
Jul 4, 2017

Conversation

brendandahl
Copy link
Contributor

…xF0FF.

Fixes #8187

@brendandahl
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.215.176.217:8877/36dd07d370dd3a5/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.67.70.0:8877/f5d88dea56d51a6/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/f5d88dea56d51a6/output.txt

Total script time: 16.54 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://54.215.176.217:8877/36dd07d370dd3a5/output.txt

Total script time: 29.23 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@brendandahl brendandahl force-pushed the cmap-3-0 branch 2 times, most recently from cbd918e to a6b79f1 Compare June 30, 2017 01:25
Snuffleupagus
Snuffleupagus approved these changes Jun 30, 2017
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the comment addressed.
Thank you for the patch!

src/core/fonts.js Outdated
// byte and it is used directly as the char code.

// When a (3, 0) cmap table is present, it is used instead but the
// spec has special rules for char codes in the range of 0xF00 to
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, and in the commit message as well, I'm assuming that it should be 0xF000 instead to match the code!?

@brendandahl brendandahl changed the title Only mask char codes of (3, 0) cmap tables in the range of 0xF00 to 0… Only mask char codes of (3, 0) cmap tables in the range of 0xF000 to 0… Jul 3, 2017
@brendandahl
Copy link
Contributor Author

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Jul 3, 2017

From: Bot.io (Windows)

Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://54.215.176.217:8877/2ad4955c83b44f4/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 3, 2017

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://54.67.70.0:8877/c44321944a6d136/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 3, 2017

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/c44321944a6d136/output.txt

Total script time: 15.46 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Jul 3, 2017

From: Bot.io (Windows)

Success

Full output at http://54.215.176.217:8877/2ad4955c83b44f4/output.txt

Total script time: 27.42 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@brendandahl brendandahl merged commit 9f5c155 into mozilla:master Jul 4, 2017
@Snuffleupagus Snuffleupagus mentioned this pull request Jul 19, 2017
Closed
movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
@brendandahl
Merge pull request mozilla#8592 from brendandahl/cmap-3-0
90d0f5d 
Only mask char codes of (3, 0) cmap tables in the range of 0xF000 to 0…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
font-conversion font-truetype
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brendandahl @pdfjsbot @Snuffleupagus @timvandermeij