Re-factor how parameters are passed to the network streams #9037
Conversation
| source.disableAutoFetch = getDefaultSetting('disableAutoFetch'); | ||
| source.disableStream = getDefaultSetting('disableStream'); | ||
| source.chunkedViewerLoading = !!pdfDataRangeTransport; |
There was a problem hiding this comment.
Removing this line isn't really relevant to the rest of the patch, but since I was touching code nearby it seemed like a nice clean-up given that this property has been unused since PR #8617.
*This patch is the result of me starting to look into moving parameters from `PDFJS` into `getDocument` and other API methods.* When familiarizing myself with the code, the signatures of the various network streams seemed to be unnecessarily cumbersome since `disableRange` is currently handled separately from other parameters. I'm assuming that the explanation for this is probably "for historical reasons", as is often the case. Hence I'd like to clean this up *before* we start the larger, and more invasive, `PDFJS` parameter re-factoring.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/9abd4e922dd49c1/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/9abd4e922dd49c1/output.txt Total script time: 2.52 mins Published |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/0ac481a7a67637a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 1 Live output at: http://54.215.176.217:8877/94db1a4e86e87cd/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/0ac481a7a67637a/output.txt Total script time: 16.96 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/94db1a4e86e87cd/output.txt Total script time: 23.90 mins
|
|
Looks better this way, thanks! |
…arams Re-factor how parameters are passed to the network streams
This patch is the result of me starting to look into moving parameters from
PDFJSintogetDocumentand other API methods.When familiarizing myself with the code, the signatures of the various network streams seemed to be unnecessarily cumbersome since
disableRangeis currently handled separately from other parameters.I'm assuming that the explanation for this is probably "for historical reasons", as is often the case. Hence I'd like to clean this up before we start the larger, and more invasive,
PDFJSparameter re-factoring.Edit: Slightly smaller diff with https://github.com/mozilla/pdf.js/pull/9037/files?w=1.