Adopt "errorprone" tool instead of Spotbugs #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compared to spotbugs, errorprone seems to run faster, finds a number of useful things, is easier to configure, and is updated often. * Add errorprone to the build for all non-test code * Suppress or disable warnings that are too much for us to fix now * Fix other errors and warnings * Remove spotbugs (it and errorprone don't always agree)
|
This change improves build times a little bit, makes the code more consistent and modern, and found three bugs:
Given that, I'm going to go ahead and merge it, although it may require be to do a bit more work on a few of the in-flight PRs. |
rbri
reviewed
Jul 23, 2024
| @@ -667,7 +666,7 @@ private Field[] getAccessibleFields(boolean includeProtected, boolean includePri | |||
| for (Field field : declared) { | |||
| int mod = field.getModifiers(); | |||
| if (includePrivate || isPublic(mod) || isProtected(mod)) { | |||
| if (!field.isAccessible()) field.setAccessible(true); | |||
| field.trySetAccessible(); | |||
There was a problem hiding this comment.
@gbrail is there any reason why we not forward this to the vm bridge?
I guess performance might be no real reason because hopefully the vm inlines the call
rbri
reviewed
Jul 23, 2024
| @@ -328,8 +328,7 @@ private void discoverAccessibleMethods( | |||
| if (isPublic(mods) || isProtected(mods) || includePrivate) { | |||
| MethodSignature sig = new MethodSignature(method); | |||
| if (!map.containsKey(sig)) { | |||
| if (includePrivate && !method.isAccessible()) | |||
| method.setAccessible(true); | |||
| if (includePrivate) method.trySetAccessible(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compared to spotbugs, errorprone seems to run faster, finds a number of
useful things, is easier to configure, and is updated often.
Other notes: