Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a benchmark to measure Rhino startup time #1582

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

gbrail
Copy link
Collaborator

@gbrail gbrail commented Aug 23, 2024

I'm a bit worried about changes I'm making with lambdas and how that will impact how long it will take Rhino to initialize all the standard objects, so let's create a microbenchmark for that.

I'm a bit worried about changes I'm making with lambdas and how that
will impact how long it will take Rhino to initialize all the standard
objects, so let's create a microbenchmark for that.
@gbrail
Copy link
Collaborator Author

gbrail commented Aug 24, 2024

In case anyone is keeping score, yes, the changes to lambda objects will slow down startup time because they create big old hash tables when "initStandardObjects" is called, although they perform as well or better later. So far we're talking about going from 17 microseconds to 22 or 23, which is not a big deal unless people start to initialize Rhino a lot, but we should keep an eye out and possibly increase usage of the "lazy" feature that we already use for these things...

@gbrail gbrail merged commit 2fdc1ef into mozilla:master Aug 24, 2024
3 checks passed
@gbrail gbrail deleted the greg-startup-benchmark branch August 24, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant