force LF as newLine character to let out test suite pass on windows also #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume this will closes #1584? |
|
Yes, this is OK and also works for me (except the Unicode thing which I appreciate you looking at. Thanks!) |
Will do, this is the next step... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves all the issues i have on windows when running our test suite. There is only one test from the test262 suite that still fails and something unicode related. Will have a look at this later and maybe prepare a separate PR.
This also fixes #918 - did a short test and it looks like spotless leaves the LF untouched.
@gbrail having this merged will be a great help - i already started with the Proxy & Reflect update and therefor having a working test suite is essential