Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set initial line number to -1 and fix StackTraceTests #1609

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

camnwalter
Copy link
Contributor

This fixes #477. I also changed the tests to match the comments in StackStyle, so they all show the line number in them.

@gbrail
Copy link
Collaborator

gbrail commented Sep 5, 2024

Cool. Thanks!

@gbrail gbrail merged commit 3577b83 into mozilla:master Sep 5, 2024
3 checks passed
@camnwalter camnwalter deleted the getlinenumbers branch September 6, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getLineNumbers misses the first line
2 participants