Make ToNumber(String) conversion more spec-compliant #383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ToNumber conversion applied to the String type:
return NaN for them
whitespace (in contrast to how 'parseInt()' works)
New behavior is applied only if the language version is >=ES6, so it
shouldn’t brake any existing code.
This also enables built-ins/Number test262 cases.
Fixes #368.
I’ve also verified that the new
ToNumberLegacyConversionsTest
works in the master branch without this patch, so it in fact represents the ToNumber's current behavior.