Use serde's OsStr and OsString impls #93
Comments
|
Thanks! |
alexcrichton
added a commit
to alexcrichton/sccache
that referenced
this issue
Apr 28, 2017
This initially started out tackling mozilla#93 and ended up plumbing the `OsStr` type basically everywhere! This knocked out a TODO or two along the way and should remove some pesky unwraps and/or error handling around handling of arguments and paths that may not be unicode. Some notable other points are: * A few utilities were added to `src/util.rs` to assist with handling os strings * The Rust implementation doesn't deal with os strings in argument parsing at all, but otherwise internally stores os strings for maximal compatibility (more comments in the code). * Some unsafe transmutes were removed in util in favor of a more stable implementation. * The `output_file` function was renamed to `output_pretty` as it turns out it's not actually the actual output file but rather just a pretty description of it (for logging and such). Closes mozilla#93
alexcrichton
added a commit
to alexcrichton/sccache
that referenced
this issue
May 3, 2017
This initially started out tackling mozilla#93 and ended up plumbing the `OsStr` type basically everywhere! This knocked out a TODO or two along the way and should remove some pesky unwraps and/or error handling around handling of arguments and paths that may not be unicode. Some notable other points are: * A few utilities were added to `src/util.rs` to assist with handling os strings * The Rust implementation doesn't deal with os strings in argument parsing at all, but otherwise internally stores os strings for maximal compatibility (more comments in the code). * Some unsafe transmutes were removed in util in favor of a more stable implementation. * The `output_file` function was renamed to `output_pretty` as it turns out it's not actually the actual output file but rather just a pretty description of it (for logging and such). Closes mozilla#93
alexcrichton
added a commit
to alexcrichton/sccache
that referenced
this issue
May 3, 2017
This initially started out tackling mozilla#93 and ended up plumbing the `OsStr` type basically everywhere! This knocked out a TODO or two along the way and should remove some pesky unwraps and/or error handling around handling of arguments and paths that may not be unicode. Some notable other points are: * A few utilities were added to `src/util.rs` to assist with handling os strings * The Rust implementation doesn't deal with os strings in argument parsing at all, but otherwise internally stores os strings for maximal compatibility (more comments in the code). * Some unsafe transmutes were removed in util in favor of a more stable implementation. * The `output_file` function was renamed to `output_pretty` as it turns out it's not actually the actual output file but rather just a pretty description of it (for logging and such). Closes mozilla#93
alexcrichton
added a commit
to alexcrichton/sccache
that referenced
this issue
May 3, 2017
This initially started out tackling mozilla#93 and ended up plumbing the `OsStr` type basically everywhere! This knocked out a TODO or two along the way and should remove some pesky unwraps and/or error handling around handling of arguments and paths that may not be unicode. Some notable other points are: * A few utilities were added to `src/util.rs` to assist with handling os strings * The Rust implementation doesn't deal with os strings in argument parsing at all, but otherwise internally stores os strings for maximal compatibility (more comments in the code). * Some unsafe transmutes were removed in util in favor of a more stable implementation. * The `output_file` function was renamed to `output_pretty` as it turns out it's not actually the actual output file but rather just a pretty description of it (for logging and such). Closes mozilla#93
alexcrichton
added a commit
to alexcrichton/sccache
that referenced
this issue
May 3, 2017
This initially started out tackling mozilla#93 and ended up plumbing the `OsStr` type basically everywhere! This knocked out a TODO or two along the way and should remove some pesky unwraps and/or error handling around handling of arguments and paths that may not be unicode. Some notable other points are: * A few utilities were added to `src/util.rs` to assist with handling os strings * The Rust implementation doesn't deal with os strings in argument parsing at all, but otherwise internally stores os strings for maximal compatibility (more comments in the code). * Some unsafe transmutes were removed in util in favor of a more stable implementation. * The `output_file` function was renamed to `output_pretty` as it turns out it's not actually the actual output file but rather just a pretty description of it (for logging and such). Closes mozilla#93
alexcrichton
added a commit
to alexcrichton/sccache
that referenced
this issue
May 3, 2017
This initially started out tackling mozilla#93 and ended up plumbing the `OsStr` type basically everywhere! This knocked out a TODO or two along the way and should remove some pesky unwraps and/or error handling around handling of arguments and paths that may not be unicode. Some notable other points are: * A few utilities were added to `src/util.rs` to assist with handling os strings * The Rust implementation doesn't deal with os strings in argument parsing at all, but otherwise internally stores os strings for maximal compatibility (more comments in the code). * Some unsafe transmutes were removed in util in favor of a more stable implementation. * The `output_file` function was renamed to `output_pretty` as it turns out it's not actually the actual output file but rather just a pretty description of it (for logging and such). Closes mozilla#93
alexcrichton
added a commit
to alexcrichton/sccache
that referenced
this issue
May 4, 2017
This initially started out tackling mozilla#93 and ended up plumbing the `OsStr` type basically everywhere! This knocked out a TODO or two along the way and should remove some pesky unwraps and/or error handling around handling of arguments and paths that may not be unicode. Some notable other points are: * A few utilities were added to `src/util.rs` to assist with handling os strings * The Rust implementation doesn't deal with os strings in argument parsing at all, but otherwise internally stores os strings for maximal compatibility (more comments in the code). * Some unsafe transmutes were removed in util in favor of a more stable implementation. * The `output_file` function was renamed to `output_pretty` as it turns out it's not actually the actual output file but rather just a pretty description of it (for logging and such). Closes mozilla#93
alexcrichton
added a commit
to alexcrichton/sccache
that referenced
this issue
May 11, 2017
This initially started out tackling mozilla#93 and ended up plumbing the `OsStr` type basically everywhere! This knocked out a TODO or two along the way and should remove some pesky unwraps and/or error handling around handling of arguments and paths that may not be unicode. Some notable other points are: * A few utilities were added to `src/util.rs` to assist with handling os strings * The Rust implementation doesn't deal with os strings in argument parsing at all, but otherwise internally stores os strings for maximal compatibility (more comments in the code). * Some unsafe transmutes were removed in util in favor of a more stable implementation. * The `output_file` function was renamed to `output_pretty` as it turns out it's not actually the actual output file but rather just a pretty description of it (for logging and such). Closes mozilla#93
alexcrichton
added a commit
to alexcrichton/sccache
that referenced
this issue
May 12, 2017
This initially started out tackling mozilla#93 and ended up plumbing the `OsStr` type basically everywhere! This knocked out a TODO or two along the way and should remove some pesky unwraps and/or error handling around handling of arguments and paths that may not be unicode. Some notable other points are: * A few utilities were added to `src/util.rs` to assist with handling os strings * The Rust implementation doesn't deal with os strings in argument parsing at all, but otherwise internally stores os strings for maximal compatibility (more comments in the code). * Some unsafe transmutes were removed in util in favor of a more stable implementation. * The `output_file` function was renamed to `output_pretty` as it turns out it's not actually the actual output file but rather just a pretty description of it (for logging and such). Closes mozilla#93
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Following up on #85 (comment):
I published Serde 0.9.12 containing Alex's impls for OsStr and OsString.
The text was updated successfully, but these errors were encountered: