-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Sccache dist tests broken after bump to tokio 1.21 and later #1563
Conversation
b1bcc0b
to
d36db7a
Compare
cc @sylvestre and @messense for review |
Ooops, freebsd still failing for dist test failed. |
Codecov ReportBase: 30.90% // Head: 30.86% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1563 +/- ##
==========================================
- Coverage 30.90% 30.86% -0.04%
==========================================
Files 48 48
Lines 16555 16298 -257
Branches 7923 7755 -168
==========================================
- Hits 5116 5031 -85
- Misses 6057 6061 +4
+ Partials 5382 5206 -176
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
9719cba
to
cb5938e
Compare
6b35a62
to
3ebad24
Compare
Signed-off-by: Xuanwo <[email protected]>
3ebad24
to
6a1ff7b
Compare
Many thanks |
@Xuanwo it seems that test ubuntu-22.04 rust 1.60.0 dist-server is failing
|
It's a long-term problem that sccache dist tests failed after bumping tokio.
After a bisect of all commits between tokio 1.20.1 to 1.21.0, I confirmed that this problem was introduced in tokio-rs/tokio#4840. The PR itself is simple and correct, but it can lead to problems in
hyper
(reqwest
affected too).After this PR, hyper can't reuse connections between different runtimes. To address this problem, we should ensure all requests sent by hyper are from the same runtime. But it's a huge change based on our current design. So in this PR, I disabled the keep-alive of reqwest to make sure everything just works as before.
Changes that are included in this PR:
keep-alive: Close
by hand, so this change won't affect of dist server's perf.localhost
with networkhost
instead ofdocker
container IPpodman-docker
without thedocker0
network bridge.tokio
andtokio-utils
Future Plan:
reqwest::blocking::Client
.Close #1541
Close #1543