Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow async functions #337

Closed
hildjj opened this issue May 9, 2018 · 3 comments
Closed

Allow async functions #337

hildjj opened this issue May 9, 2018 · 3 comments

Comments

@hildjj
Copy link
Contributor

hildjj commented May 9, 2018

Are we still limited to an old version of acorn as implied by this comment?
@fitzgen
Copy link
Contributor

fitzgen commented May 9, 2018

Not sure!

@tromey
Copy link
Contributor

tromey commented May 10, 2018

Sounds like it is fixed: webpack/webpack#2872

@hildjj
Copy link
Contributor Author

hildjj commented May 10, 2018

I tried it and it worked. After we decide #336 is ok, I may take an async pass. Let's leave this bug open for that.

hildjj added a commit to hildjj/source-map that referenced this issue May 28, 2018
@hildjj
Make async change. Fixes mozilla#337.
b73d4a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fitzgen @hildjj @tromey