Update source-map TypeScript typings to 0.7.0 #321
Merged
+49
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off: Congrats on the excellent 0.7.0 release! I look forward to measuring the performance impact on my memory leak debugger, BLeak.
The TypeScript typings contained within this repository are incorrect for the current version posted to NPM, which has breaking changes from 0.5.0. As a result, TypeScript code is unable to properly interoperate with the latest version of the library.
I have updated the typings to make the SourceMapConsumer constructors return a Promise and to add typings for the new
destroy()
andwith
methods.I have also added a
types
field topackage.json
, so users ofsource-map
can import from this module without requiring the@types/source-map
metapackage.If you accept and merge this pull request, please publish a new version of source-map to NPM with these changes so TypeScript code can interoperate with 0.7.0! Otherwise, TypeScript code will continue to use the invalid typings file published with the NPM module.