Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expected arguments to assert.throws calls #347

Merged
merged 1 commit into from
Jun 21, 2018

Conversation

Standard8
Copy link
Member

In bug 1452706 we are moving mozilla-central towards requiring the "expected" argument to Assert.throws (and friends).

This is currently an ESLint rule, however we are working on moving it to be hard-coded in Assert.jsm.

Hence, this PR updates source-map, and I'll file a bug once it is accepted to get source-map updated in mozilla-central.

@coveralls
Copy link

coveralls commented Jun 21, 2018

Pull Request Test Coverage Report for Build 493

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.919%

Totals Coverage Status
Change from base Build 492: 0.0%
Covered Lines: 908
Relevant Lines: 1051

💛 - Coveralls

Copy link
Contributor

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fitzgen fitzgen merged commit ddaac7f into mozilla:master Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants