Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump webpack-cli to v3.1 #361

Merged
merged 1 commit into from
Sep 28, 2018
Merged

Bump webpack-cli to v3.1 #361

merged 1 commit into from
Sep 28, 2018

Conversation

redeyes2015
Copy link
Contributor

@redeyes2015 redeyes2015 commented Sep 28, 2018 •
edited
Loading

webpack v4.20 introduces a change making webpack-cli v2 unusable.

Check: webpack/webpack#8082.

@redeyes2015
Bump webpack-cli to v3.1
7e6e8bf 
webpack v4.20 introduce a change making webpack-cli v2 unusable.

Check: webpack/webpack#8082.
@redeyes2015 redeyes2015 mentioned this pull request Sep 28, 2018
Closed
@coveralls
Copy link

coveralls commented Sep 28, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 504

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.898%
Totals Coverage Status
Change from base Build 498: 0.0%
Covered Lines: 910
Relevant Lines: 1053
💛 - Coveralls

@tromey
Copy link
Contributor

tromey commented Sep 28, 2018

Seems reasonable to me.

@tromey tromey merged commit d69af14 into mozilla:master Sep 28, 2018
@redeyes2015 redeyes2015 deleted the webpack-cli branch October 4, 2018 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@redeyes2015 @coveralls @tromey