Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

[Mobile] Different message displayed on iOS unsupported devices in the place of the install button location #3322

Open
SoftVision-PaulOiegas opened this issue Feb 5, 2018 · 5 comments
Labels
[QA]:Minor issue Label for QA to mark minor issues logged
Milestone

Comments

@SoftVision-PaulOiegas
Copy link

[Affected versions]:

  • Firefox 58.0.1 (mobile)

[Affected Platforms]:

  • iOS 11.2.2 (iPhone 6)

[Prerequisites]:

  • Latest Firefox browser version was installed on the mobile device.

[Steps to reproduce]:

  1. Start the Firefox iOS app and navigate to https://testpilot.dev.mozaws.net page.
  2. Observe the messages displayed in the place of the install button in the next sections
    -Homepage top part
    -Homepage bottom (above Newsletter form)
    -Experiment details page top part

[Expected result]:

  • A different message than is displayed for mobile devices than on desktop on all 3 locations. The message informs the users that "Test Pilot requires Firefox for Desktop on Windows Mac or Linux".

[Actual result]:

  • On iOS the message displayed is the same as on desktop "test Pilot is available for Firefox on Windows, OS X and Linux)"

[Notes]:

  • This also reproduces on stage server.

home top ios vs android

bottom ios vs android

exp edtails page ios vs android

@marniepw marniepw added this to the Stretch 🙆 milestone Feb 16, 2018
@chuckharmston chuckharmston modified the milestone: Stretch 🙆 Mar 19, 2018
@SoftVision-PaulOiegas SoftVision-PaulOiegas added the [QA]:Minor issue Label for QA to mark minor issues logged label May 17, 2018
@KhushilMistry
Copy link

I think this issue has been resolved.

Android

android

IOS

iphone

@SoftVision-PaulOiegas
Copy link
Author

SoftVision-PaulOiegas commented Dec 19, 2018

@KhushilMistry Wow, somehow I've missed your comment. Sadly it's not the same on the Test Pilot homepage.

screenshot_20181218-170149

I would personally go with the one on iOS for both mobile platforms, since the same message is displayed for 3rd party browsers like Edge, Chrome, etc on desktop.

@SoftVision-PaulOiegas
Copy link
Author

And if we are talking about Android vs iOS differences, found another mismatch and logged it separately #4006.

@KhushilMistry
Copy link

KhushilMistry commented Dec 22, 2018

Okay. I will make a PR for both the changes.

@KhushilMistry
Copy link

For the isFirefox in browser states, when we are running the app for the Mobile devices through Firefox Responsive Design mode, I am getting following user agent : mozilla/5.0 (linux; android 8.0.0; nexus 6p build/opp3.170518.006) applewebkit/537.36 (khtml, like gecko) chrome/67.0.3396.87 mobile safari/537.36
Its not including the "Firefox" in it so isFirefox state is being set as false and it is creating problem.
So do we need to update following function ?

export function isFirefox(ua) {
const userAgent = ua.toLowerCase();
return userAgent.includes("firefox") && !userAgent.includes("fxios");
}

Can you guide me here ? @meandavejustice

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[QA]:Minor issue Label for QA to mark minor issues logged
Projects
None yet
Development

No branches or pull requests

4 participants