Avoid using serde just for printing debug representations

examples/custom-types/Cargo.toml

@@ -13,7 +13,6 @@ name = "custom_types"
 [dependencies]
 anyhow = "1"
 bytes = "1.3"
-serde_json = "1"
 uniffi = {path = "../../uniffi", version = "0.24" }
 url = "2.2"
 

fixtures/ext-types/guid/Cargo.toml

@@ -13,7 +13,6 @@ name = "ext_types_guid"
 [dependencies]
 anyhow = "1"
 bytes = "1.3"
-serde_json = "1"
 thiserror = "1.0"
 uniffi = {path = "../../../uniffi", version = "0.24" }
 

fixtures/ext-types/http-headermap/Cargo.toml

@@ -13,7 +13,6 @@ name = "ext_types_http_headermap"
 anyhow = "1"
 bytes = "1.3"
 http = "0.2.9"
-serde_json = "1"
 thiserror = "1.0"
 uniffi = {path = "../../../uniffi", version = "0.24" }
 

uniffi/src/cli.rs

@@ -69,8 +69,8 @@ enum Commands {
         udl_file: Utf8PathBuf,
     },
 
-    /// Print the JSON representation of the interface from a dynamic library
-    PrintJson {
+    /// Print a debug representation of the interface from a dynamic library
+    PrintRepr {
         /// Path to the library file (.so, .dll, .dylib, or .a)
         path: Utf8PathBuf,
     },
@@ -128,8 +128,8 @@ pub fn run_main() -> anyhow::Result<()> {
                 !no_format,
             )?;
         }
-        Commands::PrintJson { path } => {
-            uniffi_bindgen::print_json(&path)?;
+        Commands::PrintRepr { path } => {
+            uniffi_bindgen::print_repr(&path)?;
         }
     };
     Ok(())

uniffi/src/lib.rs

@@ -17,7 +17,7 @@ pub use uniffi_bindgen::bindings::ruby::run_test as ruby_run_test;
 pub use uniffi_bindgen::bindings::swift::run_test as swift_run_test;
 #[cfg(feature = "bindgen")]
 pub use uniffi_bindgen::{
-    bindings::TargetLanguage, generate_bindings, generate_component_scaffolding, print_json,
+    bindings::TargetLanguage, generate_bindings, generate_component_scaffolding, print_repr,
 };
 #[cfg(feature = "build")]
 pub use uniffi_build::generate_scaffolding;

uniffi_bindgen/Cargo.toml

@@ -22,7 +22,6 @@ heck = "0.4"
 once_cell = "1.12"
 paste = "1.0"
 serde = "1"
-serde_json = "1.0.80"
 toml = "0.5"
 uniffi_meta = { path = "../uniffi_meta", version = "=0.24.1" }
 uniffi_testing = { path = "../uniffi_testing", version = "=0.24.1" }

uniffi_bindgen/src/lib.rs

@@ -317,13 +317,9 @@ pub fn generate_bindings(
     Ok(())
 }
 
-pub fn dump_json(library_path: &Utf8Path) -> Result<String> {
+pub fn print_repr(library_path: &Utf8Path) -> Result<()> {
     let metadata = macro_metadata::extract_from_library(library_path)?;
-    Ok(serde_json::to_string_pretty(&metadata)?)
-}
-
-pub fn print_json(library_path: &Utf8Path) -> Result<()> {
-    println!("{}", dump_json(library_path)?);
+    println!("{metadata:#?}");
     Ok(())
 }
 

uniffi_meta/Cargo.toml

@@ -11,6 +11,5 @@ keywords = ["ffi", "bindgen"]
 [dependencies]
 anyhow = "1"
 bytes = "1.3"
-serde = { version = "1.0.136", features = ["derive"] }
 siphasher = "0.3"
 uniffi_checksum_derive = { version = "0.24.1", path = "../uniffi_checksum_derive" }

uniffi_meta/src/lib.rs

@@ -5,8 +5,6 @@
 use std::{collections::BTreeMap, hash::Hasher};
 pub use uniffi_checksum_derive::Checksum;
 
-use serde::Serialize;
-
 mod ffi_names;
 pub use ffi_names::*;
 
@@ -118,7 +116,7 @@ impl Checksum for &str {
 // The namespace of a Component interface.
 //
 // This is used to match up the macro metadata with the UDL items.
-#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Serialize)]
+#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord)]
 pub struct NamespaceMetadata {
     pub crate_name: String,
     pub name: String,
@@ -127,13 +125,13 @@ pub struct NamespaceMetadata {
 // UDL file included with `include_scaffolding!()`
 //
 // This is to find the UDL files in library mode generation
-#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Serialize)]
+#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord)]
 pub struct UdlFile {
     pub module_path: String,
     pub name: String,
 }
 
-#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Serialize)]
+#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord)]
 pub struct FnMetadata {
     pub module_path: String,
     pub name: String,
@@ -154,7 +152,7 @@ impl FnMetadata {
     }
 }
 
-#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Serialize)]
+#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord)]
 pub struct ConstructorMetadata {
     pub module_path: String,
     pub self_name: String,
@@ -178,7 +176,7 @@ impl ConstructorMetadata {
     }
 }
 
-#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Serialize)]
+#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord)]
 pub struct MethodMetadata {
     pub module_path: String,
     pub self_name: String,
@@ -201,7 +199,7 @@ impl MethodMetadata {
     }
 }
 
-#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Serialize)]
+#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord)]
 pub struct TraitMethodMetadata {
     pub module_path: String,
     pub trait_name: String,
@@ -227,10 +225,9 @@ impl TraitMethodMetadata {
     }
 }
 
-#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Serialize)]
+#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord)]
 pub struct FnParamMetadata {
     pub name: String,
-    #[serde(rename = "type")]
     pub ty: Type,
     pub by_ref: bool,
     pub optional: bool,
@@ -249,7 +246,7 @@ impl FnParamMetadata {
     }
 }
 
-#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Serialize, Checksum)]
+#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Checksum)]
 pub enum LiteralMetadata {
     Boolean(bool),
     String(String),
@@ -271,50 +268,49 @@ pub enum LiteralMetadata {
 
 // Represent the radix of integer literal values.
 // We preserve the radix into the generated bindings for readability reasons.
-#[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord, Serialize, Checksum)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord, Checksum)]
 pub enum Radix {
     Decimal = 10,
     Octal = 8,
     Hexadecimal = 16,
 }
 
-#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Serialize)]
+#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord)]
 pub struct RecordMetadata {
     pub module_path: String,
     pub name: String,
     pub fields: Vec<FieldMetadata>,
 }
 
-#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Serialize)]
+#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord)]
 pub struct FieldMetadata {
     pub name: String,
-    #[serde(rename = "type")]
     pub ty: Type,
     pub default: Option<LiteralMetadata>,
 }
 
-#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Serialize)]
+#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord)]
 pub struct EnumMetadata {
     pub module_path: String,
     pub name: String,
     pub variants: Vec<VariantMetadata>,
 }
 
-#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Serialize)]
+#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord)]
 pub struct VariantMetadata {
     pub name: String,
     pub fields: Vec<FieldMetadata>,
 }
 
-#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Serialize)]
+#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord)]
 pub struct ObjectMetadata {
     pub module_path: String,
     pub name: String,
     pub imp: types::ObjectImpl,
     pub uniffi_traits: Vec<UniffiTraitMetadata>,
 }
 
-#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Serialize)]
+#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord)]
 pub struct CallbackInterfaceMetadata {
     pub module_path: String,
     pub name: String,
@@ -330,7 +326,7 @@ impl ObjectMetadata {
 }
 
 /// The list of traits we support generating helper methods for.
-#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Serialize)]
+#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord)]
 pub enum UniffiTraitMetadata {
     Debug {
         fmt: MethodMetadata,
@@ -347,7 +343,7 @@ pub enum UniffiTraitMetadata {
     },
 }
 
-#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Serialize)]
+#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord)]
 pub enum ErrorMetadata {
     Enum { enum_: EnumMetadata, is_flat: bool },
 }
@@ -366,7 +362,7 @@ impl ErrorMetadata {
     }
 }
 
-#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Serialize)]
+#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord)]
 pub struct CustomTypeMetadata {
     pub module_path: String,
     pub name: String,
@@ -384,7 +380,7 @@ pub fn checksum<T: Checksum>(val: &T) -> u16 {
 }
 
 /// Enum covering all the possible metadata types
-#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Serialize)]
+#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord)]
 pub enum Metadata {
     Namespace(NamespaceMetadata),
     UdlFile(UdlFile),

uniffi_meta/src/types.rs

@@ -17,11 +17,9 @@
 //! about how these API-level types map into the lower-level types of the FFI layer as represented
 //! by the [`ffi::FfiType`](super::ffi::FfiType) enum, but that's a detail that is invisible to end users.
 
-use serde::Serialize;
-
 use crate::Checksum;
 
-#[derive(Debug, Copy, Clone, Eq, PartialEq, Checksum, Ord, PartialOrd, Serialize)]
+#[derive(Debug, Copy, Clone, Eq, PartialEq, Checksum, Ord, PartialOrd)]
 pub enum ObjectImpl {
     Struct,
     Trait,
@@ -51,7 +49,7 @@ impl ObjectImpl {
     }
 }
 
-#[derive(Debug, Clone, Copy, Eq, PartialEq, Checksum, Ord, PartialOrd, Serialize)]
+#[derive(Debug, Clone, Copy, Eq, PartialEq, Checksum, Ord, PartialOrd)]
 pub enum ExternalKind {
     Interface,
     // Either a record or enum
@@ -61,7 +59,7 @@ pub enum ExternalKind {
 /// Represents all the different high-level types that can be used in a component interface.
 /// At this level we identify user-defined types by name, without knowing any details
 /// of their internal structure apart from what type of thing they are (record, enum, etc).
-#[derive(Debug, Clone, Eq, PartialEq, Checksum, Ord, PartialOrd, Serialize)]
+#[derive(Debug, Clone, Eq, PartialEq, Checksum, Ord, PartialOrd)]
 pub enum Type {
     // Primitive types.
     UInt8,

uniffi_testing/Cargo.toml

@@ -15,5 +15,3 @@ camino = "1.0.8"
 cargo_metadata = "0.15"
 fs-err = "2.7.0"
 once_cell = "1.12"
-serde = "1"
-serde_json = "1"