-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade syn to 2.0 #1495
Upgrade syn to 2.0 #1495
Conversation
With this we would now have both 1.0 and 2.0 as deps here. |
I think having both 1.0 and 2.0 in the tree will soon be unavoidable. dtolnay already upgraded his own (big) crates like thiserror and serde_derive. But it's not critical to have this merged soon. |
yeah, we will have to figure this out over on the m-c side eventually. |
Has this been figured out on the m-c side? Attribute parsing is a bit more convenient in syn 2.0, so it would be nice to have that new API when working on the proc-macro frontend. edit: Judging by this being the only syn package in m-c's |
I'll make myself a todo to find some people to figure this out next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got the OK to land syn v2 in m-c as well, so we can now land this. I'll work on a followup to upgrade askama and some others as well to reduce the number of crates on syn v1
@jplatte looks like this has some merge conflicts (but GitHub is acting up and not even letting me do the usual resolving in the UI?). Can you rebase this PR? |
No description provided.