embed adaptive Quantization method #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariusz-f
reviewed
Jun 4, 2024
src_base/xeve_bsw.c
Outdated
| @@ -198,7 +198,7 @@ int xeve_bsw_write(XEVE_BSW * bs, u32 val, int len) /* len(1 ~ 32) */ | |||
| int leftbits; | |||
|
|
|||
| xeve_assert(bs); | |||
| xeve_assert(len <= 32); // to avoid shifting by a negative value | |||
| //xeve_assert(len <= 32); // to avoid shifting by a negative value | |||
There was a problem hiding this comment.
Describe why this change is required?
There was a problem hiding this comment.
If adaptive quantization method functions are enabled then I receive error.
There was a problem hiding this comment.
Proper way is to solve issue not disable assert.
There was a problem hiding this comment.
Closing change as invalid.
If you have problems with adaptive quantization please open issue with description and data that allow to find root cause of problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.