Refactoring in return codes

[dariusz-f]

• Use xeve defined return codes in xeve_app
• Fix return on success in xeve_app

[kpchoi]

Any reason why the application return code need to use XEVE library return code?
We can think the application code is one of example how to use XEVE library.
It might not need to use XEVE's error definitions in there.

[dariusz-f]

Currently in xeve_app code is a mix of return codes. Some are from library and some are not. So we need to decide which is preferred way and make whole implementation consistent.

[mpeg5]

@dariusz-f ,
I think the application don't have to follow xeve return values.
The popular application in this area is 'ffmpeg' as you know.
ffmpeg is a application using codec libraries, for example libxeve.
it doesn't follow codec libraries' return value. it has own definition of return code.
Of course xeve application can also define own return values internally as like ffmpeg.
But main purpose of xeve application is not commercial level application but testing use-case.
So, the application may not need own return value definition to distinguish many types run-time error.
It is reason why the application code is using the conventional return code like 0 (zero) for success and -1 (negative) for failure.

Again,
#137 is relating to this issue.
The following code may not be correct in xeve_app.c
ret value should not be set to XEVE_ERR_XXX code.

    /* update rate controller parameters */
    if (update_fps_param(args, param))
    {
      logerr("fps is not proper\n");
      ret = XEVE_ERR; goto ERR;
    }

    /* update rate controller parameters */
    if (update_rc_param(args, param))
    {
        logerr("parameters for rate control is not proper\n");
        ret = XEVE_ERR; goto ERR;
    }
    /* update vui parameters */
    if (update_vui_param(args, param))
    {
        logerr("vui parameters is not proper\n");
        ret = XEVE_ERR; goto ERR;
    }
    /* update sei parameters */
    if (update_sei_param(args, param))
    {
        logerr("sei parameters is not proper\n");
        ret = XEVE_ERR; goto ERR;
    }

    /* VUI parameter Range Checking*/
    if (vui_param_check(param))
    {
        logerr("VUI Parameter out of range\n");
        ret = XEVE_ERR; goto ERR;
    }

[dariusz-f]

Ok I will refactor whole app to return 0 and -1 instead of XEVE_OK and XEVE_ERR.

[kpchoi]

@dariusz-f
Could you check #137 issue?
I think there might be code returning library return code in somewhere.
The issue says that return code is XEVE_OK_NO_MORE_FRM.
It might be relating to bumping process...

[dariusz-f]

When there is no error then return is set to 0.
Below line fixes issue #137

xeve/app/xeve_app.c

Line 1428 in 06f5f47

ret = 0;

[kpchoi]

LGTM