Abstract common logic for clients #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpiorowski
requested changes
Aug 14, 2023
client/src/lib/server/grpc.ts
Outdated
| @@ -25,44 +25,37 @@ export const proto = loadPackageDefinition( | |||
| packageDefinition, | |||
| ) as unknown as ProtoGrpcType; | |||
|
|
|||
| export const usersRustClient = new proto.proto.UsersService( | |||
| URI_USERS_RUST, | |||
| const getCertificate = () => | |||
There was a problem hiding this comment.
Good idea, can i just ask for a small change? I am a type fo guy that use const for variables, and function for functions ;p
So just change the keyword? :) And there is a missing return type.
mpiorowski
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstracting this logic should help keep it maintainable. Since each client should use a unique certificate, this was kept as a function rather than saving one certificate.