Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update arm64 Dockerfile to build audio support #296

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

s-fairchild
Copy link
Contributor

@s-fairchild s-fairchild commented Nov 22, 2022

I would like to update the arm64 Dockerfile to support alsa.

Description

This is to update the arm64 Dockerfile to build alsa support.

Related Issue

#295

Motivation and Context

I use this project on some of my arm machines and rather than rebuilding the containers locally, I think it would be beneficial to have the upstream arm64 images support alsa.

It prevents users from rebuilding the arm64 docker images to support alsa.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

I'm not sure if there's a reason audio support wasn't being built in the arm64 images, I would like to update the arm64 Dockerfile to support alsa.
@mpromonet
Copy link
Owner

Hi @s-fairchild

Thanks for the contribution.

Best Regards,
Michel.

@mpromonet mpromonet merged commit 9af7e4f into mpromonet:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants