Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

Added commands and fixed some errors #83

Merged
merged 1 commit into from
Apr 3, 2016

Conversation

geriko7
Copy link
Contributor

@geriko7 geriko7 commented Apr 3, 2016

I have added 3 commands:
-Low Ammo , Target Neutralized , KIA/Lost one

Fixed 2 command:
-Wait for me
-Take Cover

I have added 3 commands:
-Low Ammo , Target Neutralized , KIA/Lost one

Fixed 2 command:
-Wait for me
-Take Cover
@notheotherben
Copy link
Collaborator

Hi @geriko7,
Thanks for this 👍 I'll see if I can get my local build environment setup again and will package a new release as soon as that's done.

@notheotherben notheotherben merged commit a273972 into mpstark:master Apr 3, 2016
@geriko7
Copy link
Contributor Author

geriko7 commented Apr 6, 2016

Hey there,
Thanks for putting it in, but in the latest release it's not working.
I didn't find anything and I don't know a lot about it, so can you take a look at the files?

@notheotherben
Copy link
Collaborator

Certainly, sorry about that - will check as soon as I get home after work

@geriko7
Copy link
Contributor Author

geriko7 commented Apr 6, 2016

Thank you! Looking forward to your reply!

@notheotherben
Copy link
Collaborator

Hi @geriko7,
I unfortunately wasn't able to reproduce any crash (I assume that you're referring to a crash when you say "it's not working"). I've included a couple of other fixes and tweaks to try and track down any crashes if that is the case - so if you wouldn't mind trying out v0.2.9 I'd appreciate it.

EDIT: v0.2.9 also fixes the Hungarian translation you included in #84 not being present in the app - let me know if that was the issue you mentioned.

Regards,
Benjamin

@geriko7
Copy link
Contributor Author

geriko7 commented Apr 6, 2016

Thanks for your reply!

Actually, the Hungarian translation was only one of the issues. The other was, that when I said any commands that I've put in the software, wasn't working. It didn't understand my pronunciations. I've tried all of these commands. Did it work for you?

Best Regards,
Gary Raven

@notheotherben
Copy link
Collaborator

Commands appear to work for me, however you need to remember to say a unit group before the command itself, so "all, be advised, low fuel" should work. That's a limitation of the grammar used currently, it's of the form [subject] [command] (direction).

Before the project sort of closed down, Michael and I were looking at implementing a custom grammar syntax which would have allowed greater flexibility here, but unfortunately we never got around to finishing it (it's a rather complex task to undertake, especially when you need to bind it to keystroke sequences, and while trying to keep it compact).

@geriko7 geriko7 deleted the patch-1 branch April 6, 2016 16:34
@geriko7
Copy link
Contributor Author

geriko7 commented Apr 6, 2016

Yeah, yeah... Thank you. Now it's working.
Anyway, thank you for fixing the grammar problems in the commands!
It'd be good to make a custom grammar syntax, because in status actions It's bad to say the [subject] first, it'd be good to make to say only command.
Soon I'll go and work on it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants