Add test for the SocketOptionFactory::buildLiteralOptions() method. (e…

…nvoyproxy#6724) Signed-off-by: Yan Avlasov <[email protected]>
mpuncel · May 1, 2019 · f129e5e · f129e5e
1 parent 4769552
commit f129e5e
Show file tree

Hide file tree

Showing 2 changed files with 48 additions and 0 deletions.
diff --git a/test/common/network/BUILD b/test/common/network/BUILD
@@ -235,6 +235,7 @@ envoy_cc_test(
 envoy_cc_test(
     name = "socket_option_factory_test",
     srcs = ["socket_option_factory_test.cc"],
+    external_deps = ["abseil_str_format"],
     deps = [
         "//source/common/network:address_lib",
         "//source/common/network:socket_option_factory_lib",

diff --git a/test/common/network/socket_option_factory_test.cc b/test/common/network/socket_option_factory_test.cc
@@ -6,6 +6,7 @@
 #include "test/mocks/network/mocks.h"
 #include "test/test_common/threadsafe_singleton_injector.h"
 
+#include "absl/strings/str_format.h"
 #include "gtest/gtest.h"
 
 using testing::_;
@@ -123,6 +124,52 @@ TEST_F(SocketOptionFactoryTest, TestBuildIpv6TransparentOptions) {
                                             envoy::api::v2::core::SocketOption::STATE_BOUND));
 }
 
+TEST_F(SocketOptionFactoryTest, TestBuildLiteralOptions) {
+  Protobuf::RepeatedPtrField<envoy::api::v2::core::SocketOption> socket_options_proto;
+  Envoy::Protobuf::TextFormat::Parser parser;
+  envoy::api::v2::core::SocketOption socket_option_proto;
+  static const char linger_option_format[] = R"proto(
+    state: STATE_PREBIND
+    level: %d
+    name: %d
+    buf_value: "\x01\x00\x00\x00\x80\x0d\x00\x00"
+  )proto";
+  auto linger_option = absl::StrFormat(linger_option_format, SOL_SOCKET, SO_LINGER);
+  ASSERT_TRUE(parser.ParseFromString(linger_option, &socket_option_proto));
+  *socket_options_proto.Add() = socket_option_proto;
+  static const char keepalive_option_format[] = R"proto(
+    state: STATE_PREBIND
+    level: %d
+    name: %d
+    int_value: 1
+  )proto";
+  auto keepalive_option = absl::StrFormat(keepalive_option_format, SOL_SOCKET, SO_KEEPALIVE);
+  ASSERT_TRUE(parser.ParseFromString(keepalive_option, &socket_option_proto));
+  *socket_options_proto.Add() = socket_option_proto;
+
+  auto socket_options = SocketOptionFactory::buildLiteralOptions(socket_options_proto);
+  EXPECT_EQ(2, socket_options->size());
+  auto option_details = socket_options->at(0)->getOptionDetails(
+      socket_mock_, envoy::api::v2::core::SocketOption::STATE_PREBIND);
+  EXPECT_TRUE(option_details.has_value());
+  EXPECT_EQ(SOL_SOCKET, option_details->name_->first);
+  EXPECT_EQ(SO_LINGER, option_details->name_->second);
+  EXPECT_EQ(sizeof(struct linger), option_details->value_.size());
+  const struct linger* linger_ptr =
+      reinterpret_cast<const struct linger*>(option_details->value_.data());
+  EXPECT_EQ(1, linger_ptr->l_onoff);
+  EXPECT_EQ(3456, linger_ptr->l_linger);
+
+  option_details = socket_options->at(1)->getOptionDetails(
+      socket_mock_, envoy::api::v2::core::SocketOption::STATE_PREBIND);
+  EXPECT_TRUE(option_details.has_value());
+  EXPECT_EQ(SOL_SOCKET, option_details->name_->first);
+  EXPECT_EQ(SO_KEEPALIVE, option_details->name_->second);
+  EXPECT_EQ(sizeof(int), option_details->value_.size());
+  const int* flag_ptr = reinterpret_cast<const int*>(option_details->value_.data());
+  EXPECT_EQ(1, *flag_ptr);
+}
+
 } // namespace
 } // namespace Network
 } // namespace Envoy