osc: avoid showing a double-minus-sign for time remaining

[rcombs]

Previously, if the current timestamp exceeded the nominal duration of the file (possible if the duration was incorrect, stream durations mismatched, etc), the time-remaining field would show eg "--00:00:00".

With this change, it instead shows "00:00:00".

The single minus sign is still present (to keep the field width consistent), but drawn fully transparent.

I considered showing a plus sign instead, but this ends up looking pretty awkward baseline-rendering-wise, and results in a size jump as "-" is replaced by the wider "+" if the unicodeminus setting isn't enabled.

[Dudemanguy]

time-remaining should already be returning M_PROPERTY_UNAVAILABLE if the calculated time is bogus so I think we should just take that into account instead of trying to apply cosmetics?

mpv/player/command.c

Lines 853 to 854 in a61518d

	if (!time_remaining(ctx, &remaining))
	return M_PROPERTY_UNAVAILABLE;

[rcombs]

time_remaining can (and does) output a negative number (and return true) if the playhead is beyond the demuxer-provided duration. In most cases this is just a frame or so beyond the nominal duration, but it can be longer in some cases, and I think it's still worth displaying for consistency if nothing else; "the playhead is currently 5 seconds beyond where we expected the file to end" is meaningful information.

[github-actions]

Download the artifacts for this pull request:

Windows

• mpv-i686-w64-mingw32
• mpv-x86_64-w64-mingw32
• mpv-x86_64-windows-msvc

macOS

• mpv-macos-13-intel
• mpv-macos-14-arm
• mpv-macos-15-arm

[Dudemanguy]

Oh I see I misread the condition. I kind of disagree though. I don't see what's useful about negative numbers in the time-remaining and similar properties. Seems like just junk information to me.