Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cocoa: fix drawing on macOS 10.14 #6283

Merged
merged 1 commit into from
Nov 13, 2018
Merged

cocoa: fix drawing on macOS 10.14 #6283

merged 1 commit into from
Nov 13, 2018

Conversation

Akemi
Copy link
Member

@Akemi Akemi commented Nov 4, 2018

filling both NSViews with any colour fixes the blank screen on macOS 10.14. though i have no bloody clue why it does that.

anyway i deprecated the cocoa backend and don't really care, though if we want to keep it (even if just for reference) it should at least draw something.

there are still all the other various issues. on resize the content behind the window flickers through and i am not sure if this is a new or old issue.

@Akemi
Copy link
Member Author

Akemi commented Nov 4, 2018

on a side note, this was a proposed fix that works for various other projects but not for us.

Copy link
Member

@jeeb jeeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jeeb jeeb merged commit b222980 into mpv-player:master Nov 13, 2018
@Akemi Akemi deleted the cocoa_fix branch November 13, 2018 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants