vo_gpu/d3d11: add support for configuring swap chain output format #7051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And if backbuffer is not around, return an error value utilized elsewhere already.
ghost
reviewed
Oct 12, 2019
ghost
reviewed
Oct 12, 2019
|
Seems sane, but I don't know this D3D stuff much. |
jeeb
force-pushed
the
d3d11_output_format_support
branch
from
bc36c50 to
e95d165
Compare
rossy
reviewed
Oct 13, 2019
jeeb
force-pushed
the
d3d11_output_format_support
branch
from
e95d165 to
98ebc00
Compare
Query information on the system output most linked to the swap chain, and either utilize a user-configured format, or either 8bit RGBA or 10bit RGB with 2bit alpha depending on the system output's bit depth.
jeeb
force-pushed
the
d3d11_output_format_support
branch
from
98ebc00 to
35f17cf
Compare
rossy
approved these changes
Oct 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of getting to color space configuration (HDR and such).
Adds support for configuring the D3D11 swap chain format. For now we have been utilizing 8bit RGBA, but other formats are available, such as 10bit RGB with 2bit alpha, 16bit floating point or 8bit BGRA.
The APIs querying the system output's information is surprisingly new, so the Windows dxgi header check is bumped from
dxgi1_2.htodxgi1_6.h(this is available at the very least on mingw-w64 6.x). The code should still work on Windows 7+, but the system output information will only be available for Windows 10 users at least according to what MSDN says..Current logic:
Additionally, adds @rossy 's fix for the rendering bit depth that I have fixed up somewhat.
Fixes #5237 .