Patch for a shorthand definition of quoted fields in http_urllib #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add list shorthand for params dict + allow optional params in query string
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #691 +/- ##
==========================================
- Coverage 49.75% 49.60% -0.15%
==========================================
Files 81 81
Lines 4034 4046 +12
==========================================
Hits 2007 2007
- Misses 2027 2039 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
this one had two bugs, creating new PR |
amotl
requested review from
jpmens and
sumnerboy12
and removed request for
jpmens and
sumnerboy12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with a greater number of transformed fields (e. g. through topic's alldata), the params definition for the target has a lot of redundancy, especially when the field names are crafted to be the parameter names of the query parameters:
This patch provides a shorthand for a definition like
[ #method, #url, { 'param1' : '@param1', ..., 'paramN': '@paramN' }, ...by allowing lists for the 3rd parameter of the target definition:
[ #method, #url, [ '?param1', ..., '?paramN' ], ...If a list is provided
[ 'param1', ..., 'paramN' ]will be interpreted as[ '@param1', ..., '@paramN' ]?, fields can be declared optional: they will not be included in the query if the data is invalid or missing from item.data{};[ 'param1', '?param2', ... ]