Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/connect/tls.js opts.servername parameter is not set #1049

Closed
mishindm opened this issue Feb 17, 2020 · 3 comments
Closed

lib/connect/tls.js opts.servername parameter is not set #1049

mishindm opened this issue Feb 17, 2020 · 3 comments
Labels

Comments

@mishindm
Copy link

In the function buildBuilder the opts.servername is not set, so TLS SNI is not working.

  • opts.servername = opts.hostname

fixes the issue when SNI is required

YoDaMa pushed a commit that referenced this issue Feb 21, 2020
Co-authored-by: ewan-chalmers <[email protected]>
@ewan-chalmers
Copy link
Contributor

I believe the fixed is resolved in master by #1055

@github-actions
Copy link

This is an automated message to let you know that this issue has
gone 365 days without any activity. In order to ensure that we work
on issues that still matter, this issue will be closed in 14 days.

If this issue is still important, you can simply comment with a
"bump" to keep it open.

Thank you for your contribution.

@github-actions github-actions bot added the stale label Oct 15, 2022
@github-actions
Copy link

This issue was automatically closed due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants