feat: support SNI on TLS #1055
Merged
feat: support SNI on TLS #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ewan-chalmers <[email protected]>
mcollina
reviewed
Feb 24, 2020
| @@ -153,5 +154,33 @@ describe('MqttSecureClient', function () { | |||
| done() | |||
| }) | |||
| }) | |||
|
|
|||
| it.only('should support SNI on the TLS connection', function (done) { | |||
There was a problem hiding this comment.
This should not have landed as it has a only still in the tests.
There was a problem hiding this comment.
yes I'll revert it, I just wasn't getting Travis CI to even identify the branch to run testing.
YoDaMa
pushed a commit
to YoDaMa/MQTT.js
that referenced
this pull request
Feb 24, 2020
This reverts commit f6534c2.
PremiumBurger
pushed a commit
to quickstar/MQTT.js
that referenced
this pull request
Nov 27, 2020
Co-authored-by: ewan-chalmers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
carryover with tests of #1050