Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move cli to bin directory #1096

Merged
merged 1 commit into from
May 11, 2020
Merged

chore: move cli to bin directory #1096

merged 1 commit into from
May 11, 2020

Conversation

OmgImAlexis
Copy link
Contributor

This hasn't been fully verified but it should fix #1008

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit e3ea11a into mqttjs:master May 11, 2020
Copy link

@DavidMG01 DavidMG01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not working....

@OmgImAlexis
Copy link
Contributor Author

What isn’t? You kinda need to provide details for us to help.

@DavidMG01
Copy link

What isn’t? You kinda need to provide details for us to help.

The mqtt.js into bin directory refers to ./bin/pub and ./bin/sub, but these are in the same directory, I corrected the references to ./pub and ./sub but fail all...

If you install gobally and check may be you see the issue.

@OmgImAlexis
Copy link
Contributor Author

I’ll check in the morning and open a PR.

@YoDaMa YoDaMa mentioned this pull request May 29, 2020
PremiumBurger pushed a commit to quickstar/MQTT.js that referenced this pull request Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building with Webpack have issues with #!/usr/bin/env node in mqtt.js
3 participants