Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set default value false for reconnecting in constructor (#1674) #1678

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

davdeo
Copy link
Contributor

@davdeo davdeo commented Aug 23, 2023

This is my first pullrequest, did I do everything correct?
Do I need to extend the documentation or something?

I dont know what branch to set as target, please feel free to change the target to a "correct" branch.

@robertsLando robertsLando changed the title fix: Add default value false for reconnecting in constructor (#1674) fix: set default value false for reconnecting in constructor (#1674) Aug 29, 2023
@robertsLando robertsLando enabled auto-merge (squash) August 29, 2023 10:31
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (57f4595) 81.08% compared to head (33e83dd) 81.09%.
Report is 3 commits behind head on main.

❗ Current head 33e83dd differs from pull request most recent head 2d17b2d. Consider uploading reports for the commit 2d17b2d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1678      +/-   ##
==========================================
+ Coverage   81.08%   81.09%   +0.01%     
==========================================
  Files          21       21              
  Lines        1364     1365       +1     
  Branches      322      322              
==========================================
+ Hits         1106     1107       +1     
  Misses        181      181              
  Partials       77       77              
Files Changed Coverage Δ
src/lib/client.ts 85.83% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robertsLando robertsLando disabled auto-merge August 30, 2023 06:45
@robertsLando robertsLando merged commit 312b57b into mqttjs:main Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants