Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjusted global handling to fix web worker environment issue #1747

Closed
wants to merge 1 commit into from
Closed

fix: adjusted global handling to fix web worker environment issue #1747

wants to merge 1 commit into from

Conversation

hibrandonevans
Copy link
Contributor

@hibrandonevans hibrandonevans commented Nov 29, 2023

This pull request addresses the issue reported in #1748 , where our package faced compatibility issues within the Web Worker environment due to incorrect global scope handling. Specifically, the problem was that global was getting replaced with window during the packaging process.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (de89c0d) 79.47% compared to head (7cb02ab) 79.47%.

Files Patch % Lines
src/lib/client.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1747   +/-   ##
=======================================
  Coverage   79.47%   79.47%           
=======================================
  Files          23       23           
  Lines        1403     1403           
  Branches      329      329           
=======================================
  Hits         1115     1115           
  Misses        209      209           
  Partials       79       79           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robertsLando
Copy link
Member

@hibrandonevans AFAIK globalThis is just an alias for global, I don't understand how this could fix the problem, did you try to run esbuild to see if this change fixes your problem? I think this should be fixed on esbuild side

@robertsLando
Copy link
Member

Supersided by #1749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants