-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: timerVariant
option to choose between native and worker timers
#1818
feat: timerVariant
option to choose between native and worker timers
#1818
Conversation
timerVariant
options to choose between native and worker timers
timerVariant
options to choose between native and worker timerstimerVariant
option to choose between native and worker timers
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1818 +/- ##
==========================================
- Coverage 81.02% 79.27% -1.76%
==========================================
Files 24 25 +1
Lines 1402 1438 +36
Branches 330 335 +5
==========================================
+ Hits 1136 1140 +4
- Misses 183 215 +32
Partials 83 83 ☔ View full report in Codecov by Sentry. |
@robertsLando what about the codecov issue, do you have a suggestion how to test it? or just dummy test case |
@olso-nordsec unfortunately codecov doesn't consider the coverage of tests running on browser (with |
@olso-nordsec FYI: #1819 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing now, fix them (I think last change did something wrong)
In order to only trigger pingtimer tests you can use node -r esbuild-register --test test/pingTimer.ts
@olso-nordsec The problem is that test rely on |
@olso-nordsec news here? |
@robertsLando it was weekend, will look at it today 🙏 |
@olso-nordsec Yeah no worries, thanks 🙏🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
Closes #1806