-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt the generate_beta function to take two parameters #21
Comments
What are the two parameters needed? Currently we have an initial beta, a reduction factor, and a period over which the reduction occurs |
We might everything we want already then. I guess it would be better to be able to specify beta1 and beta2 (so before and after) or beta 1 and then reduction (as it is now). |
I can change that. Do you have a sensible beta start and beta end value to use as default? |
This function is used in the grid search and MCMC to generate the beta range from a start point. We should generalise this to make it a closure in these cases, so the user can use different parameters for effect and period of reduction |
Allow the function to take two parameters instead of one, if the second parameter is not specified, used the current reduction.
The text was updated successfully, but these errors were encountered: