Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt the generate_beta function to take two parameters #21

Closed
MJomaba opened this issue Apr 6, 2020 · 5 comments · Fixed by #46 or #50
Closed

Adapt the generate_beta function to take two parameters #21

MJomaba opened this issue Apr 6, 2020 · 5 comments · Fixed by #46 or #50
Assignees

Comments

@MJomaba
Copy link
Contributor

MJomaba commented Apr 6, 2020

Allow the function to take two parameters instead of one, if the second parameter is not specified, used the current reduction.

@MJomaba
Copy link
Contributor Author

MJomaba commented Apr 6, 2020

@johnlees

@johnlees
Copy link
Member

johnlees commented Apr 6, 2020

What are the two parameters needed? Currently we have an initial beta, a reduction factor, and a period over which the reduction occurs

@johnlees johnlees self-assigned this Apr 6, 2020
@MJomaba
Copy link
Contributor Author

MJomaba commented Apr 6, 2020

We might everything we want already then. I guess it would be better to be able to specify beta1 and beta2 (so before and after) or beta 1 and then reduction (as it is now).

@johnlees
Copy link
Member

johnlees commented Apr 6, 2020

I can change that. Do you have a sensible beta start and beta end value to use as default?

@johnlees
Copy link
Member

johnlees commented Apr 7, 2020

This function is used in the grid search and MCMC to generate the beta range from a start point. We should generalise this to make it a closure in these cases, so the user can use different parameters for effect and period of reduction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants