feat(lsp): Arguments to explainError/renderDiagnostic from current line #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review ChecklistDoes this PR follow the Contribution Guidelines? Following is a partial checklist: Proper conventional commit scoping:
If applicable:
|
Rumi152
changed the title
|
Its my first more serious pull request so I'm sorry if I did something wrong, I don't know how to install nix on windows |
|
Hey, thanks for the contribution. 🙏 I'm quite busy at the moment but I'll make sure to give it a review and a test drive in the next few days 😃 |
mrcjkb
requested changes
Jun 21, 2024
|
CI is failing because stylua needs to be run. |
Co-authored-by: Marc Jakobi <[email protected]>
Co-authored-by: Marc Jakobi <[email protected]>
Co-authored-by: Marc Jakobi <[email protected]>
mrcjkb
approved these changes
Jun 21, 2024
mrcjkb
requested changes
Jun 21, 2024
|
I'll try to figure it out |
|
I think it should work now |
mrcjkb
reviewed
Jun 21, 2024
mrcjkb
approved these changes
Jun 21, 2024
|
Sorry for all the headache I've caused and thanks for this great plugin 😄 |
This was referenced Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(lsp): explainError and renderDiagnostic command now have optional argument {cycle?|current?}. It default to cycle which is current behavior, current option makes it search for diagnostic only in the current cursor line