Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dap): use integrated terminal for lldb-dap by default #494

Merged
merged 1 commit into from
Sep 10, 2024
Merged

feat(dap): use integrated terminal for lldb-dap by default #494

merged 1 commit into from
Sep 10, 2024

Conversation

adonis0147
Copy link
Contributor

Description

lldb-dap has supported integrated terminal and we can use this feature by default which is consistent with the behavior of codelldb.

Environment

OS: macOS 14.6.1
Arch: arm64
LLVM: 18.1.8

Snapshot

Snipaste_2024-09-05_21-05-21

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.
  • Updated CHANGELOG.md

Copy link
Owner

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@mrcjkb mrcjkb changed the title feat(lldb-dap): use integrated terminal for lldb-dap by default feat(dap): use integrated terminal for lldb-dap by default Sep 6, 2024
@mrcjkb mrcjkb merged commit c3729ed into mrcjkb:master Sep 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants