Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(mason): more generic config snippet #550

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

arthur-cahu
Copy link
Contributor

Hey, thanks for the great plugin !

Long story short, I've noticed that the executable name for the latest rust-analyzer shipped by Mason differs between OSes, but we can retrieve that from the metadata provided by Mason.

I've modified the docs in kind, but would be happy to contribute to a more automated discovery mechanism if desirable.

Hope this helps 🦀

Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.

Copy link
Owner

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks 🙏

@mrcjkb mrcjkb enabled auto-merge (squash) October 21, 2024 22:21
@mrcjkb mrcjkb merged commit f9b22ae into mrcjkb:master Oct 21, 2024
6 checks passed
@arthur-cahu arthur-cahu deleted the mason branch October 22, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants