-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converted to ES6 modules #72
Conversation
Thanks! |
I'm the one thanking. I admire and appreciate all the amazing and hard work you've done for the open source community. |
FYI This PR breaks stats.js when retreived over bower. Bower recommends you use the un-minified version as your main (which stats.js does), and the |
Thanks for reporting this! I haven't used it with bower before – I'll look at it |
I just tested this myself with bower, npm and normal script tag in the latest Chrome and didn't get any issues or syntax errors. screenshot Can you post the error you got, and information about browser? |
Yes, "overrides": {
"stats.js": {
"main": "build/stats.min.js"
}
} |
If you aren't seeing an error, then I am assuming you are using |
Also, in case I am making it sound like the solution is to change |
So what we need is to also provide a none-minified ES5 version? |
@terkelg make |
@Disorrder and @cfresh thank you so much for the feedback, I really appricate that. Can you guys test this build: https://github.com/terkelg/stats.js - If it works, I'll make a pull request |
The build on your fork works in my setup, thanks! |
Converted to ES6 modules and Rollup, in a way very similar to the latest ThreeJS changes (#9310).
I also updated the closure compiler and added a few NPM scripts.