Surport for OpenGL ES rendering. #13046
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. You don't need to include |
|
Yes please, do not include the builds files in the PR. |
|
Also, in which environment are you getting |
|
@mrdoob maybe WeChat small program |
finscn
reviewed
Jan 31, 2018
| var versionString = gl.getParameter(gl.VERSION); | ||
| var lineWidthAvailable = false; | ||
| var version = 0.0; | ||
| if(versionString.indexOf("WebGL") != -1) |
finscn
reviewed
Jan 31, 2018
| version = parseFloat( /^WebGL\ ([0-9])/.exec( gl.getParameter( gl.VERSION ) )[ 1 ] ); | ||
| lineWidthAvailable = parseFloat( version ) >= 1.0; | ||
| } | ||
| else if(versionString.indexOf("OpenGL ES") != -1) |
finscn
reviewed
Jan 31, 2018
| else if(versionString.indexOf("OpenGL ES") != -1) | ||
| { | ||
| version = parseFloat( /^OpenGL ES\ ([0-9])/.exec( gl.getParameter( gl.VERSION ) )[ 1 ] ); | ||
| lineWidthAvailable = parseFloat( version ) >= 2.0; |
There was a problem hiding this comment.
We don't need parseFloat again
finscn
reviewed
Jan 31, 2018
| if(versionString.indexOf("WebGL") != -1) | ||
| { | ||
| version = parseFloat( /^WebGL\ ([0-9])/.exec( gl.getParameter( gl.VERSION ) )[ 1 ] ); | ||
| lineWidthAvailable = parseFloat( version ) >= 1.0; |
There was a problem hiding this comment.
We don't need parseFloat again
finscn
reviewed
Jan 31, 2018
| var version = 0.0; | ||
| if(versionString.indexOf("WebGL") != -1) | ||
| { | ||
| version = parseFloat( /^WebGL\ ([0-9])/.exec( gl.getParameter( gl.VERSION ) )[ 1 ] ); |
There was a problem hiding this comment.
use versionString instead of call gl.getParameter( gl.VERSION ) again
finscn
reviewed
Jan 31, 2018
| } | ||
| else if(versionString.indexOf("OpenGL ES") != -1) | ||
| { | ||
| version = parseFloat( /^OpenGL ES\ ([0-9])/.exec( gl.getParameter( gl.VERSION ) )[ 1 ] ); |
There was a problem hiding this comment.
use versionString instead of call gl.getParameter( gl.VERSION ) again
|
#13211 was merged instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed an bug when i migrated to my android phone, because my gl version string is "OpenGL ES 3.2 v1.r12p1-04bet0.76b1d268c59a490265a02c702c8aa55c"