WebGPURenderer: Restore instanced multi-draw API and add WebGPU support #28759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrdoob
pushed a commit
that referenced
this pull request
Jul 2, 2024
…rt (#28759) * WebGPURenderer: Restore instanced multi-draw API and WebGPU compatibility * fix firefox since gl_drawID is not mandatory for custom usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #28103, #28753
Description
This PR aligns behavior with the
WebGLRenderer. I mistakenly removed theobject._multiDrawInstancescondition in #28753 and it seems that some developers/companies might have already implemented custom multi-draw classes in user-land, andobject._multiDrawInstanceswill provide such an alternative as mentioned in #28103.This increases flexibility for developers by not limiting the use of the multi-draw API to the current BatchMesh system, which can be restrictive.
Regarding TSL, no action is needed as this is already a quite advanced use case. Developers can override the
BatchNodefor their custom implementation viasetupPosition.This contribution is funded by Utsubo