Examples: Fix delay when switching between orbit and pan mode #30252
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm afraid I don't understand the issue. I can't reproduce a lag on a Mac mini with Chrome. |
|
Strange, I am getting the issue when using trackpad on M1 MacBook Pro. I am using three finger drag for panning if it matters... 
|
|
By lag I mean I expect orbit control to activate as soon as shift is released but the pan mode sticks for a few extra ms after releasing shift. If the issue can't be reproduced then I'm fine with just using my custom orbit control implementation locally and closing this PR lol |
|
Let's keep this PR open for a bit, especially since you have provided test links. Maybe someone else can reproduce. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is lag when switching between orbit and pan controls, leading to poor user experience
Example with fix
Example without fix
Screen.Recording.2025-01-02.at.10.44.19.AM.mov