Restore original camera FOV and Zoom after XR presentation ends #30374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
|
Hi, I noticed that the camera FOV had changed from 50 to 74.999. So I made this changes in case you find it useful. Best regards |
src/renderers/webxr/WebXRManager.js
Outdated
Comment on lines
636
to
641
| if ( camera.userData.previousFov === undefined ) { | ||
|
|
||
| camera.userData.previousFov = camera.fov; | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
Camera fov and zoom should be memoized at the top-level of this class and overriden/restored on sessionstart and sessionend. You will find this for renderer properties, and it would be the same here.
WebGLRender has been restored, now it is not involved at all.
|
Code has been updated as per comments |
ramonmata
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #XXXX
Description
This change restores the fov value of the camera before entering a WebXR session.