Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix video decoder stalls issue in webgpu_video_frame.html" #30384

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jan 22, 2025

Reverts #30380

@Mugen87 Mugen87 merged commit 3fefbf2 into dev Jan 22, 2025
1 of 2 checks passed
@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jan 22, 2025

@ycw Sorry, I had to revert. On macOS and Chrome, the demo throws now runtime errors:

Uncaught OperationError: Failed to execute 'importExternalTexture' on 'GPUDevice': Failed to import texture from video frame that doesn't have back resource
at WebGPUBindingUtils.createBindGroup (WebGPUBindingUtils.js:399:1)
at WebGPUBindingUtils.createBindings (WebGPUBindingUtils.js:263:1)
at WebGPUBackend.updateBindings (WebGPUBackend.js:1703:1)
at Bindings._update (Bindings.js:304:1)
at Bindings._updateBindings (Bindings.js:165:1)
at Bindings.updateForRender (Bindings.js:152:1)
at WebGPURenderer._renderObjectDirect (Renderer.js:2776:1)
at WebGPURenderer.renderObject (Renderer.js:2715:1)
at WebGPURenderer._renderObjects (Renderer.js:2630:1)
at WebGPURenderer._renderScene (Renderer.js:1368:1)

@Mugen87 Mugen87 deleted the revert-30380-quickfix-videoframe branch January 22, 2025 21:04
@ycw
Copy link
Contributor

ycw commented Jan 22, 2025

it's because you removed scene.remove( mesh ) by accident at 299364c :D

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jan 22, 2025

Oh dear! Do you think you can remake the PR with the scene.remove( mesh statement? Sorry for the back-and-forth. Just trying to reduce the code we need to a bare minimum.

@ycw
Copy link
Contributor

ycw commented Jan 22, 2025

no problem. at #30385. FWIW, it should be fine to keep render the mesh IF this TODO is fixed 🤷🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants