Skip to content

Commit

Permalink
Comment out mix check in build script
Browse files Browse the repository at this point in the history
  • Loading branch information
mreishus committed Mar 10, 2020
1 parent a5cfb41 commit 52888c7
Showing 1 changed file with 15 additions and 1 deletion.
16 changes: 15 additions & 1 deletion build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,21 @@ VERSION=1.0.10 # Bump in AboutIndex.tsx too
# exit when any command fails
set -e

mix check
# mix check
# Mix check commented out
# Router fails after upgrading phoenix - not sure what this is about.
echo "Please run 'mix check' manually and verify the results."
echo "This isn't automated because there's a dialyzer error in the "
echo "phoenix router. I don't think it's my fault, but I don't "
echo "know how to fix it either."
echo " "

read -p "Are you sure you want to build? " -n 1 -r
echo # (optional) move to a new line
if [[ ! $REPLY =~ ^[Yy]$ ]]
then
[[ "$0" = "$BASH_SOURCE" ]] && exit 1 || return 1 # handle exits from shell or function but don't exit interactive shell
fi

echo "Building..."
docker build --tag=mreishus/sbin:$VERSION --tag=mreishus/sbin:latest .
Expand Down

2 comments on commit 52888c7

@mreishus
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug is in phoenix: phoenixframework/phoenix#3697

@mreishus
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in Phoenix 1.4.16

Please sign in to comment.