Replace image cropping with image scaling #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you @MuchtarSalimov I'll be able to have a look at this in the next few days :) |
ghost
approved these changes
Jun 12, 2019
There was a problem hiding this comment.
@mrhut10 Finally had a look at this, I tested it locally working a treat. Thank you @MuchtarSalimov, sorry it took so long.
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #33 requests images over a certain size be scaled down to a width of 2000 instead of being cropped down. This change addresses that issue.
I have confirmed the cropping issue with the current build and tested that it is no longer present with the changes.