Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined subroutine &Garmin::FIT::unpackfiltr_uint64 called #27

Open
mipapo opened this issue Aug 20, 2020 · 2 comments
Open

Undefined subroutine &Garmin::FIT::unpackfiltr_uint64 called #27

mipapo opened this issue Aug 20, 2020 · 2 comments

Comments

@mipapo
Copy link

mipapo commented Aug 20, 2020

Do you have an idea how to fix it?

1828c26f-0824-48d8-a72c-e1266850a158.new (1).zip

@laufhannes
Copy link

I guess those are simple typos (...filtr_... instead of ...filter_...):

--- call/perl/Garmin/FIT.pm	(revision 0629082504e7db4f8e2320873b10203b1062c1d7)
+++ call/perl/Garmin/FIT.pm	(date 1598856390075)
@@ -831,10 +831,10 @@
 else {
   $template[FIT_SINT64] = $template[FIT_UINT64] = $template[FIT_UINT64Z] = 'L';
   $packfactor[FIT_SINT64] = $packfactor[FIT_UINT64] = $packfactor[FIT_UINT64Z] = 2;
-  $packfilter[FIT_SINT64] = \&packfiltr_sint64;
-  $unpackfilter[FIT_SINT64] = \&unpackfiltr_sint64;
-  $packfilter[FIT_UINT64] = $packfilter[FIT_UINT64Z] = \&packfiltr_uint64;
-  $unpackfilter[FIT_UINT64] = $unpackfilter[FIT_UINT64Z] = \&unpackfiltr_uint64;
+  $packfilter[FIT_SINT64] = \&packfilter_sint64;
+  $unpackfilter[FIT_SINT64] = \&unpackfilter_sint64;
+  $packfilter[FIT_UINT64] = $packfilter[FIT_UINT64Z] = \&packfilter_uint64;
+  $unpackfilter[FIT_UINT64] = $unpackfilter[FIT_UINT64Z] = \&unpackfilter_uint64;
 }
 
 %named_type =

@mrihtar
Copy link
Owner

mrihtar commented Sep 7, 2020

Support for 64-bit integers is not tested at all and needs more investigation (quote from the original author Mr. Suto).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants