fix basis pursuit pics when using a sampling pattern #285
+18
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtamir
changed the title
|
The issue with the previous code/test is that the initialization only matters for bpsense when the sampling pattern is not all-ones. The new test uses a sampling pattern and checks the data consistency error instead of reconstruction error |
|
I'm getting failed tests that as far as I can tell are unrelated, and do not fail on my machine. Any ideas? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@uecker not sure if you would prefer to add
conf.bpsenseto the if case or just re-initialize even if loop flags is zero.TODO before accepting the PR: figure out why the bpsense tests didn't fail.