Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix basis pursuit pics when using a sampling pattern #285

Merged
merged 4 commits into from
Jun 1, 2022
Merged

Conversation

jtamir
Copy link
Member

@jtamir jtamir commented May 31, 2022

@uecker not sure if you would prefer to add conf.bpsense to the if case or just re-initialize even if loop flags is zero.

TODO before accepting the PR: figure out why the bpsense tests didn't fail.

@jtamir jtamir closed this May 31, 2022
@jtamir jtamir changed the title re-initialize sense op even if no loop flags fix basis pursuit pics when using a sampling pattern Jun 1, 2022
@jtamir
Copy link
Member Author

jtamir commented Jun 1, 2022

The issue with the previous code/test is that the initialization only matters for bpsense when the sampling pattern is not all-ones. The new test uses a sampling pattern and checks the data consistency error instead of reconstruction error

@jtamir jtamir reopened this Jun 1, 2022
@jtamir
Copy link
Member Author

jtamir commented Jun 1, 2022

I'm getting failed tests that as far as I can tell are unrelated, and do not fail on my machine. Any ideas?

@uecker uecker merged commit 66d1f4c into master Jun 1, 2022
@jtamir jtamir deleted the fix_bpsense branch June 1, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants