Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce constraints to MonadIO where possible #27 #28

Merged
merged 1 commit into from
Jul 12, 2017

Conversation

snoyberg
Copy link
Contributor

There are two things worth noting here:

  1. ignoringAbsence and forgivingAbsence cannot have their types relaxed since they take an m action as an argument.
  2. Technically speaking, modification to the methods in the AnyPath class could cause breakage, and therefore this may deserve a major version bump. However, my understanding is that these instances are only defined internally, and therefore there is no external breakage. In any event, depending on how you feel, I see three choices here:
    1. Keep the changes as I wrote them here
    2. Roll back the changes to AnyPath
    3. Make this a major version bump instead

@mrkkrp
Copy link
Owner

mrkkrp commented Jul 12, 2017

I think minor version bump is OK here, AnyPath should be a closed type class, but we don't have them in the language.

@mrkkrp mrkkrp merged commit 33d7782 into mrkkrp:master Jul 12, 2017
@mrkkrp
Copy link
Owner

mrkkrp commented Jul 12, 2017

Thank you, 1.3.2 will be on Hackage today.

@snoyberg
Copy link
Contributor Author

snoyberg commented Jul 12, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants