Update Heroku instructions in README #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
commented
Sep 7, 2024
| @@ -235,9 +209,6 @@ The Python bootstrapping process will appear in the log first, followed by the R | |||
| and so on. PyCall should now be able to successfully call Python functions from | |||
| within the Heroku environment. | |||
|
|
|||
| NB It is also possible to specify buildpacks within Docker images on Heroku. | |||
There was a problem hiding this comment.
This removal is since the Heroku container deploy feature now only supports plain Dockerfile deploys, and not the previous experimental heroku.yml + buildpacks feature.
Since Heroku's Python builds now use `--enable-shared` (for Python 3.10 and newer), so use of custom builds or a custom buildpack is no longer required. See: heroku/heroku-buildpack-python#1320 https://github.com/heroku/heroku-buildpack-python/blob/928d0c593f6b6def16d6ad8451f56a997760eace/builds/build_python_runtime.sh#L117-L133 In addition the Python buildpack now supports the `.python-version` file (and recommends it over `runtime.txt`): https://devcenter.heroku.com/changelog-items/3005
|
I've rebased on @mrkn I don't suppose you could mark the pending GitHub Actions workflow as allowed, so it can run? :-) |
|
@mrkn Please could this be merged? The current docs are broken (the tag no longer exists etc). |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Heroku's Python builds now use
--enable-shared(for Python 3.10 and newer), so use of custom builds or a custom buildpack is no longer required - since everything now works with the official buildpack.See:
heroku/heroku-buildpack-python#1320
https://github.com/heroku/heroku-buildpack-python/blob/928d0c593f6b6def16d6ad8451f56a997760eace/builds/build_python_runtime.sh#L117-L133
In addition the Python buildpack now supports the
.python-versionfile (and recommends it overruntime.txt):https://devcenter.heroku.com/changelog-items/3005