Update MutableStateParameter to catch Mutable(Int,Float,etc)State #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ong)State I didn't have time to test this (sorry) but I wanted to make this quick PR anyways since it seemed the easiest way to flag this issue. Feel free to push any updates and merge if you agree that we should also be catching these relatively new mutable state classes as well. (Disclaimer: I'm not a regex expert... which is why I prefixed this description with the fact that I didn't test this haha)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MutableStateParameter catches
MutableStateright now but not things likeMutableIntStateorMutableFloatState.This PR fixes the check so that something like the below example is flagged as an error:
(Disclaimer: I'm not a regex expert... would appreciate if you could double check I got it right because I don't have an easy way to test right now :D)